Hi Nightfox,

Today I finally upgraded my system to the latest SBBS using Git... Things went very well, but I do have one issue I can't figure out.

I'm using your DDMsg and DDFile Area Choosers, I have them in /sbbs/mods (both the .js and the .cfg). I've edited my 'default.src' and compiled it into 'default.bin', also in /sbbs/mods. It all works except for this:

For my 'J' command key definition, I've defined it as:
exec "?DDMsgAreaChooser.js" as per the instructions. It works fine.
Also defined the '/*' key the exact same way and it works.
For my '*' key, I don't want the user to see the list of message groups first, just the areas in the current group, so I have defined that one as:
exec "?DDMsgAreaChooser.js false" , again as per the instructions. But it doesn't work - when the '*' is pressed it just flickers and does nothing.

All of this holds true for the equivalent commands for "DDFileAreaChooser" as well. Exact same behavior. Basically it doesn't seem to like the command line parameter "false". For grins, I tried using "true" there, and it worked. I know that isn't needed but it was for testing.

This used to work before my upgrade. I am using slightly newer versions of your stuff, the ones that came in with the Git clone into /sbbs/xtrn/DDAreaChoosers.

Any ideas? Anybody else seeing this? Thanks for any help you can provide.

---
þ Synchronet þ Palantir BBS * palantirbbs.ddns.net * Pensacola, FL

Re: DDMsg and DDFile area choosers
By: Gamgee to Nightfox on Sat Oct 31 2020 07:19 pm

Today I finally upgraded my system to the latest SBBS using Git... Things went very well, but I do have one issue I can't figure out.

I'm using your DDMsg and DDFile Area Choosers, I have them in /sbbs/mods (both the .js and the .cfg). I've edited my 'default.src' and compiled it into 'default.bin', also in /sbbs/mods. It all works except for this:

For my 'J' command key definition, I've defined it as:
exec "?DDMsgAreaChooser.js" as per the instructions. It works fine.
Also defined the '/*' key the exact same way and it works.
For my '*' key, I don't want the user to see the list of message groups first, just the areas in the current group, so I have defined that one as:

...

Any ideas? Anybody else seeing this? Thanks for any help you can provide.

I'm running a fairly recent build (September 28), and I haven't seen any issues with it. Not sure..

Nightfox

---
þ Synchronet þ Digital Distortion: digitaldistortionbbs.com

Nightfox wrote to Gamgee <=-

Today I finally upgraded my system to the latest SBBS using Git... Things went very well, but I do have one issue I can't figure out.

I'm using your DDMsg and DDFile Area Choosers, I have them in /sbbs/mods (both the .js and the .cfg). I've edited my 'default.src' and compiled it into 'default.bin', also in /sbbs/mods. It all works except for this:

For my 'J' command key definition, I've defined it as:
exec "?DDMsgAreaChooser.js" as per the instructions. It works fine.
Also defined the '/*' key the exact same way and it works.
For my '*' key, I don't want the user to see the list of message groups first, just the areas in the current group, so I have defined that one as:

...

Any ideas? Anybody else seeing this? Thanks for any help you can provide.

I'm running a fairly recent build (September 28), and I haven't
seen any issues with it. Not sure..

Okay, I've done some further testing, and have found that the
prior version I was using (dated 2019-08-24 ver 1.19) works fine.
Without changing anything else, if I drop in the newest DDMsg and
DDFile (.js and .cfg), it does not work with the "false" command
line parameter added. Same default.src/.bin with both.

So it seems that something is not liking the word "false" with the
latest version that comes with Git... Thanks.



... Internal Error: The system has been taken over by sheep at line 19960
--- MultiMail/Linux v0.52
þ Synchronet þ Palantir BBS * palantirbbs.ddns.net * Pensacola, FL

Re: Re: DDMsg and DDFile area choosers
By: Gamgee to Nightfox on Sat Oct 31 2020 09:58 pm

Okay, I've done some further testing, and have found that the
prior version I was using (dated 2019-08-24 ver 1.19) works fine.
Without changing anything else, if I drop in the newest DDMsg and
DDFile (.js and .cfg), it does not work with the "false" command
line parameter added. Same default.src/.bin with both.

So it seems that something is not liking the word "false" with the
latest version that comes with Git... Thanks.

When you say "drop in the newest" ones, do you mean you were using older ones? What versions worked, and which don't? If you open one of the .js files, near the top, it has a variable that stores which version it is. For instance, the message area chooser has this (for version 1.20):

var DD_MSG_AREA_CHOOSER_VERSION = "1.20";
var DD_MSG_AREA_CHOOSER_VER_DATE = "2020-04-19";

I haven't updated them since before the switch to Git, and the latest I've committed was 1.20. So there should be no difference between the latest from CVS and the latest from Git. So if there's some behavioral difference, I'm not sure if Git itself would have anything to do with that - Different line endings, a different text encoding, etc..

Nightfox

---
þ Synchronet þ Digital Distortion: digitaldistortionbbs.com

Nightfox wrote to Gamgee <=-

Re: Re: DDMsg and DDFile area choosers
By: Gamgee to Nightfox on Sat Oct 31 2020 09:58 pm

Okay, I've done some further testing, and have found that the
prior version I was using (dated 2019-08-24 ver 1.19) works fine.
Without changing anything else, if I drop in the newest DDMsg and
DDFile (.js and .cfg), it does not work with the "false" command
line parameter added. Same default.src/.bin with both.

So it seems that something is not liking the word "false" with the
latest version that comes with Git... Thanks.

When you say "drop in the newest" ones, do you mean you were
using older ones? What versions worked, and which don't? If you
open one of the .js files, near the top, it has a variable that
stores which version it is. For instance, the message area
chooser has this (for version 1.20):

var DD_MSG_AREA_CHOOSER_VERSION = "1.20";
var DD_MSG_AREA_CHOOSER_VER_DATE = "2020-04-19";

On the latest SBBS, installed yesterday from Git, version 1.20
does not work, and version 1.19 does work.

When I say "does not work", let me clarify... It works *except*
when you try to pass the command line parameter "false". I'm
doing that in a modified command shell, like this:

cmdkey *
exec "?DDMsgAreaChooser.js false"
end_cmd

That command line results in a brief screen flash when the * key
is pressed, but no other action.

The exact same command shell works fine if I replace the DD files
(two .js and two .cfg) with the 1.19 versions. The .cfg files are
un-modified in both cases.

I haven't updated them since before the switch to Git, and the
latest I've committed was 1.20. So there should be no difference
between the latest from CVS and the latest from Git. So if
there's some behavioral difference, I'm not sure if Git itself
would have anything to do with that - Different line endings, a
different text encoding, etc..

Not sure what's happened either, but just letting you know what
it's doing for me. This is on Linux if that matters. It seems
that they (both DDFile and DDMsg) are not liking the word "false"
being passed on the command line.



... Internal Error: The system has been taken over by sheep at line 19960
--- MultiMail/Linux v0.52
þ Synchronet þ Palantir BBS * palantirbbs.ddns.net * Pensacola, FL

Re: Re: DDMsg and DDFile area choosers
By: Gamgee to Nightfox on Sun Nov 01 2020 06:43 am

When I say "does not work", let me clarify... It works *except*
when you try to pass the command line parameter "false". I'm
doing that in a modified command shell, like this:

cmdkey *
exec "?DDMsgAreaChooser.js false"
end_cmd

You're right, I tested it just now and it doesn't seem to work. I actually haven't used that feature of my own chooser in a while.. I'll have to have a look and see if I can fix it.

Nightfox

---
þ Synchronet þ Digital Distortion: digitaldistortionbbs.com

Nightfox wrote to Gamgee <=-

Re: Re: DDMsg and DDFile area choosers
By: Gamgee to Nightfox on Sun Nov 01 2020 06:43 am

When I say "does not work", let me clarify... It works *except*
when you try to pass the command line parameter "false". I'm
doing that in a modified command shell, like this:

cmdkey *
exec "?DDMsgAreaChooser.js false"
end_cmd

You're right, I tested it just now and it doesn't seem to work.
I actually haven't used that feature of my own chooser in a
while.. I'll have to have a look and see if I can fix it.

Thanks! Really appreciate your efforts. Again, if it helps to
locate the issue, it does work correctly in v1.19 but not in
v1.20.


... Internal Error: The system has been taken over by sheep at line 19960
--- MultiMail/Linux v0.52
þ Synchronet þ Palantir BBS * palantirbbs.ddns.net * Pensacola, FL