1. Forum
  2. DOVE-Net
  3. Synchronet Programming

  • src/sbbs3/bat_xfer.cpp

    From Rob Swindell@VERT to Git commit to main/sbbs/master on Sat Oct 23 10:06:56 2021
    https://gitlab.synchro.net/main/sbbs/-/commit/7dc1bc798e5a06e2278711ea
    Modified Files:
    src/sbbs3/bat_xfer.cpp
    Log Message:
    Fix segfault after batch-upload when no "uploads" dir specified

    When there's no "uploads" directory configured by the sysop, cfg.upload_dir will be set to INVALID_DIR, which cannot be used as an index into cfg.dir[] to determine if the time used for uploading the files should be "given back" to the user.

    In v3.18, we used the first file in the upload queue, if there was one, else fell back to the "uploads" dir (which had to have been defined if there were no files in the queue). So this illegal array indexing was a regression in v3.19.

    Reported by Zoltán Gábor on Facebook

    ---
    ï¿­ Synchronet ï¿­ Vertrauen ï¿­ Home of Synchronet ï¿­ [vert/cvs/bbs].synchro.net
  • From Rob Swindell@VERT to Git commit to main/sbbs/master on Wed Feb 23 23:25:45 2022
    https://gitlab.synchro.net/main/sbbs/-/commit/51e80cb165b7f4a1e096a172
    Modified Files:
    src/sbbs3/bat_xfer.cpp
    Log Message:
    Fix potential divide by zero

    CID 330961

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Rob Swindell@VERT to Git commit to main/sbbs/master on Wed Feb 23 23:29:23 2022
    https://gitlab.synchro.net/main/sbbs/-/commit/7e5ab9ab05d3a20fc6446e83
    Modified Files:
    src/sbbs3/bat_xfer.cpp
    Log Message:
    Just use our local C macro MAX()

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Rob Swindell@VERT to Git commit to main/sbbs/master on Wed Apr 27 20:51:49 2022
    https://gitlab.synchro.net/main/sbbs/-/commit/d785ec9fc194d967e7bcda6d
    Modified Files:
    src/sbbs3/bat_xfer.cpp
    Log Message:
    Add a sort (alphabetical) option when listing batch queues

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Rob Swindell@VERT to Git commit to main/sbbs/master on Thu Apr 28 14:05:48 2022
    https://gitlab.synchro.net/main/sbbs/-/commit/7696a52f02540c1b5347ae8f
    Modified Files:
    src/sbbs3/bat_xfer.cpp
    Log Message:
    Sort the batch queues in the .ini files as well

    This insures that the 'R'emove file option will work correctly if when displayed sorted.

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Rob Swindell@VERT to Git commit to main/sbbs/master on Fri Dec 30 02:22:55 2022
    https://gitlab.synchro.net/main/sbbs/-/commit/a0ce3cd799d2a79e4f0b5e0b
    Modified Files:
    src/sbbs3/bat_xfer.cpp
    Log Message:
    Use the user's default download protocol for batch downloads

    Oversight probably during the new filebase overhaul in v3.19. Reported by Nelgin.

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Rob Swindell (in GitKraken)@VERT to Git commit to main/sbbs/master on Thu Mar 2 18:56:50 2023
    https://gitlab.synchro.net/main/sbbs/-/commit/5d1d586fd74709f9cd1a9fc3
    Modified Files:
    src/sbbs3/bat_xfer.cpp
    Log Message:
    Better access enforcement to files in batch download queues

    If a file gets added to a batch download queue that a user doesn't have download-access to (at the time of batch download), deal with that gracefully and consistently.

    start_batch_download():
    - Now checks current user access to download the file in both single-file and batch modes
    - Now performs credit-check in single-file mode (wasn't doing so previously)
    - totalsize of multi-file batch download queue is now calculated again (apparently removed/broken in the new filebase conversion of v3.19), so download ETA should be calculated more accurately (?) again
    - Use gettimetodl() to calculate each file's download time for multi-file downloads
    - Using new putnode_download() method to write node downloading "action" and ETA-in-aux fields
    - The node status wasn't being updated at all before start of download in single-file mode - fixed

    create_batchdn_lst() :
    - Checks each file still downloadable by the user and if not, removes from the queue (and the generated list file).
    - Performs credit check and removes files that exceed available user credit
    - returns true only when 1 or more files is added to the batch download list file

    addtobatdl()
    - Removed redundant 'D' restriction check - this is handled by can_user_download() check already.
    - Use the 'reason' out parameter from can_user_download() to determine which error string to display (not always CantDownloadFromDir).

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Rob Swindell (on Debian Linux)@VERT to Git commit to main/sbbs/master on Fri Mar 3 18:00:28 2023
    https://gitlab.synchro.net/main/sbbs/-/commit/9a79d265b21f513e06c98907
    Modified Files:
    src/sbbs3/bat_xfer.cpp
    Log Message:
    Fix missing 'autohang' argument in call to protocol()

    Caught by a GCC warning.

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Rob Swindell (on Debian Linux)@VERT to Git commit to main/sbbs/master on Tue Mar 5 15:37:58 2024
    https://gitlab.synchro.net/main/sbbs/-/commit/e487e3cdb5ea842006d5dd6d
    Modified Files:
    src/sbbs3/bat_xfer.cpp
    Log Message:
    Fix warning about impossible condition.

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net