1. Forum
  2. DOVE-Net
  3. Synchronet Programming

  • src/sbbs3/services.c

    From Rob Swindell@VERT to Git commit to main/sbbs/master on Tue Mar 1 22:43:08 2022
    https://gitlab.synchro.net/main/sbbs/-/commit/7117b4d8a85474975ea81c78
    Modified Files:
    src/sbbs3/services.c
    Log Message:
    Probably doesn't resolve the Coverity issue

    But good practice anyway

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Rob Swindell@VERT to Git commit to main/sbbs/master on Wed May 11 00:37:31 2022
    https://gitlab.synchro.net/main/sbbs/-/commit/b293b6e53e751fff783f90c2
    Modified Files:
    src/sbbs3/services.c
    Log Message:
    Allow a per-service "LowestLogLevel" setting

    Have a service (e.g. imapservice.js) that logs errors that you'd rather not fill your error.log file with? Set that service's "LowestLogLevel" to "Warning" in your services.ini file ("lower" means "more severe" when it comes to log levels, so this would set the maximum severity to Warning).

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Rob Swindell@VERT to Git commit to main/sbbs/master on Sun Aug 21 18:35:34 2022
    https://gitlab.synchro.net/main/sbbs/-/commit/9bd552ed13142092f54e2b2b
    Modified Files:
    src/sbbs3/services.c
    Log Message:
    Improve JavaScript-related error messages and fix potential JS runtime leak

    If a new JS context could not be created for any reason, a JS runtime would still be allocated (and leaked), potentially leading to out of memory situations which had been seen (before this change) on vert.synchro.net.

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Rob Swindell (on ChromeOS)@VERT to Git commit to main/sbbs/master on Thu Jan 26 23:45:00 2023
    https://gitlab.synchro.net/main/sbbs/-/commit/4d8bb33e8ffd2e37e5e7b4ba
    Modified Files:
    src/sbbs3/services.c
    Log Message:
    Use XSAFECOPY in place of SAFECOPY to avoid NULL pointer checks

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Rob Swindell (in GitKraken)@VERT to Git commit to main/sbbs/master on Sun Mar 12 00:00:02 2023
    https://gitlab.synchro.net/main/sbbs/-/commit/f40e7fbd4471344721a998e9
    Modified Files:
    src/sbbs3/services.c
    Log Message:
    Fix a couple of potential NULL-pointer deferences in js_initcx() failure cases

    service_client->client is NULL in these failure/error cases, so get the protocol string from the service_client->service (which is not NULL) instead.

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Rob Swindell (on Windows)@VERT to Git commit to main/sbbs/master on Mon May 1 12:00:24 2023
    https://gitlab.synchro.net/main/sbbs/-/commit/d057ff6d2d14f5be4e219833
    Modified Files:
    src/sbbs3/services.c
    Log Message:
    Fix valgrind-reported memleak (on recycle), not freeing interfaces string list

    (seeing a pattern here) :-)

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Rob Swindell (on Windows 11)@VERT to Git commit to main/sbbs/master on Sun Dec 17 01:14:27 2023
    https://gitlab.synchro.net/main/sbbs/-/commit/41b6e894c55e20e20a4aae64
    Modified Files:
    src/sbbs3/services.c
    Log Message:
    Log client IP address in "Logging in" log message

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Rob Swindell (on Windows 11)@VERT to Git commit to main/sbbs/master on Sun Dec 17 01:37:48 2023
    https://gitlab.synchro.net/main/sbbs/-/commit/76706b71762af88781ab5922
    Modified Files:
    src/sbbs3/services.c
    Log Message:
    Fix bug in previous commit: wrong client->addr

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Deucе@VERT to Git commit to main/sbbs/master on Mon Jan 29 11:42:45 2024
    https://gitlab.synchro.net/main/sbbs/-/commit/5634092ad3f89d6e63fd52d9
    Modified Files:
    src/sbbs3/services.c
    Log Message:
    Fix apparent session leak in services.

    It appears that after successful completion of a JS service, the
    TLS session is never destroyed.

    If this fix isn't valid for #707, we should see a bunch of
    "Destroying a session (...) that's not in sess_list" log messages

    Thanks Keyop!

    ---
    ï¿­ Synchronet ï¿­ Vertrauen ï¿­ Home of Synchronet ï¿­ [vert/cvs/bbs].synchro.net
  • From Deucе@VERT to Git commit to main/sbbs/master on Wed Feb 7 14:47:35 2024
    https://gitlab.synchro.net/main/sbbs/-/commit/9c9d6a151e2f7fa2e19305e9
    Modified Files:
    src/sbbs3/services.c
    Log Message:
    Another time_t printf

    ---
    ï¿­ Synchronet ï¿­ Vertrauen ï¿­ Home of Synchronet ï¿­ [vert/cvs/bbs].synchro.net
  • From Rob Swindell (on Windows 11)@VERT to Git commit to main/sbbs/master on Thu Jul 11 18:32:37 2024
    https://gitlab.synchro.net/main/sbbs/-/commit/8dfbba2f749476ede8d78dc2
    Modified Files:
    src/sbbs3/services.c
    Log Message:
    Track/log/publish-to-MQTT services server (total) client highwater mark

    Like the other servers.

    A sysop likely would want to know which services/protocols had what
    utilization (as a portion of the total highwater mark), so that'll have to
    be added later.

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net